Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all CC_USE_RGBE_OUTPUT #17549

Merged
merged 2 commits into from
Aug 16, 2024
Merged

remove all CC_USE_RGBE_OUTPUT #17549

merged 2 commits into from
Aug 16, 2024

Conversation

star-e
Copy link
Contributor

@star-e star-e commented Aug 16, 2024

https://github.com/cocos/3d-tasks/issues/18426

remove all duplicated CC_USE_RGBE_OUTPUT.

It's better not to add CC_USE_RGBE_OUTPUT multiple times.

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Greptile Summary

This pull request simplifies the rendering pipeline code by removing redundant CC_USE_RGBE_OUTPUT macro usage in the ProbeHelperQueue class.

  • Refactored removeMacro method in cocos/rendering/custom/web-pipeline-types.ts to use Array.filter() for improved readability
  • Eliminated duplicate CC_USE_RGBE_OUTPUT macro checks, streamlining the code
  • Enhanced maintainability of the rendering pipeline implementation

@star-e star-e requested a review from GengineJS August 16, 2024 08:22
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings

cocos/rendering/custom/web-pipeline-types.ts Outdated Show resolved Hide resolved
@star-e
Copy link
Contributor Author

star-e commented Aug 16, 2024

企业微信截图_1723796632994
If all CC_USE_RGBE_OUTPUT are removed.
企业微信截图_17237966929315
If only one CC_USE_RGBE_OUTPUT is removed.

Editor will draw skybox before scene camera. The behavior is special here.

Copy link

Interface Check Report

This pull request does not change any public interfaces !

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@star-e star-e requested a review from minggo August 16, 2024 08:43
@star-e star-e merged commit 515ef06 into cocos:v3.8.4 Aug 16, 2024
10 checks passed
@star-e star-e deleted the v3.8.4-pipeline branch August 16, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants